Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable rubocop on CI #25

Merged
merged 3 commits into from
Apr 7, 2022
Merged

Enable rubocop on CI #25

merged 3 commits into from
Apr 7, 2022

Conversation

bastelfreak
Copy link
Member

No description provided.

@bastelfreak bastelfreak self-assigned this Apr 7, 2022
@bastelfreak bastelfreak force-pushed the githubactions2 branch 6 times, most recently from cb294ac to 909e9c4 Compare April 7, 2022 09:30
@bastelfreak bastelfreak force-pushed the githubactions2 branch 4 times, most recently from 32dff7d to 795670d Compare April 7, 2022 09:40
@rwaffen
Copy link
Member

rwaffen commented Apr 7, 2022

does this obsoletes #11 ?

@bastelfreak
Copy link
Member Author

yes. with the subtle difference that all current rubocop violations are allowed. that enables us to move forward with the CI setup and it's active for future changes.

@bastelfreak bastelfreak merged commit 893c71a into main Apr 7, 2022
@bastelfreak bastelfreak deleted the githubactions2 branch April 7, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwaffen rwaffen rwaffen approved these changes

Assignees

@bastelfreak bastelfreak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastelfreak @rwaffen